Skip to content

Add RTSS mailbox overlays for Lemans and Monaco targets#675

Open
snegi-qti wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
snegi-qti:qcom-6.18.y
Open

Add RTSS mailbox overlays for Lemans and Monaco targets#675
snegi-qti wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
snegi-qti:qcom-6.18.y

Conversation

@snegi-qti

@snegi-qti snegi-qti commented Jun 8, 2026

Copy link
Copy Markdown

Add RTSS mailbox overlays for Lemans and Monaco platforms providing:

ipcc_computeL1: IPCC Compute-L1 controller
rtss_mailbox: RTSS Mailbox device node
Also add IPCC_CLIENT_RTSS0/1/2/3 client ID definitions to the qcom-ipcc dt-bindings header.

CRs-Fixed: 4557036
QLIJIRA: https://jira-dc.qualcomm.com/jira/browse/QLIJIRA-123

@qlijarvis

Copy link
Copy Markdown

PR #675 — validate-patch

PR: #675

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #675 - Add RTSS Mailbox support for Lemans and Monaco platforms
Upstream commit: N/A (vendor-only QCLINUX patches)
Verdict: ✅ PASS


Patch 1/3: QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only patch; no upstream equivalent
Body preserves rationale Clear description of added client IDs and purpose
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor contribution

Diff

File Status Notes
include/dt-bindings/mailbox/qcom-ipcc.h Adds 4 new RTSS client ID definitions (27-30) in correct sequence

Patch 2/3: QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only patch; no upstream equivalent
Body preserves rationale Describes overlay purpose and key nodes
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor contribution

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds lemans-rtss-mb.dtbo build target
arch/arm64/boot/dts/qcom/lemans-rtss-mb.dtso New 65-line overlay with IPCC controller and RTSS mailbox nodes

Patch 3/3: QCLINUX: arm64: dts: qcom: monaco: Add RTSS Mailbox device tree overlay

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only patch; no upstream equivalent
Body preserves rationale Describes overlay purpose and key nodes
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor contribution

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds monaco-rtss-mb.dtbo build target
arch/arm64/boot/dts/qcom/monaco-rtss-mb.dtso New 65-line overlay with IPCC controller and RTSS mailbox nodes

Observations

Positive:

  • All three commits follow consistent QCLINUX vendor-patch conventions
  • Commit messages are clear and describe the purpose of each change
  • Proper Signed-off-by trailers present on all commits
  • Logical patch series: dt-bindings first, then platform-specific overlays
  • Both device tree overlays use proper SPDX license identifier (BSD-3-Clause)
  • Consistent structure between lemans and monaco overlays

Notes:

  • The monaco and lemans overlay files are identical (both 65 lines, same content). This may be intentional if both platforms share identical RTSS mailbox hardware configuration, but worth confirming this is not a copy-paste error.
  • Both overlays reference memory regions (sail_mailbox_mem, sail_ota_mem) that must be defined in the base device tree

Verdict

Merge as-is. All three commits are well-formed vendor patches with clear commit messages, proper authorship, and clean diffs. The patch series follows logical ordering (bindings → platform support).


Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #675 — checker-log-analyzer

PR: #675
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27152253258

Checker Result Summary
Checker Result Summary
checkpatch All 3 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check All device tree blobs validated successfully
sparse-check Sparse static analysis passed
check-uapi-headers No changes to UAPI headers detected
check-patch-compliance FAILED - All 3 commits missing required subject prefix
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable - commits use QCLINUX: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #675 - RTSS Mailbox device tree overlay support for Lemans and Monaco platforms
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27152253258

Checker Result Summary
checkpatch All 3 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check All device tree blobs validated successfully
sparse-check Sparse static analysis passed
check-uapi-headers No changes to UAPI headers detected
check-patch-compliance FAILED - All 3 commits missing required subject prefix
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable - commits use QCLINUX: prefix

❌ check-patch-compliance

Root cause: All three commit subjects use the QCLINUX: prefix instead of a required upstream-style prefix.

Failure details:

2026-06-08T16:51:57.1449846Z Checking commit: QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs
2026-06-08T16:51:57.1464379Z Commit summary does not start with a required prefix
2026-06-08T16:51:57.1512875Z Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay
2026-06-08T16:51:57.1527752Z Commit summary does not start with a required prefix
2026-06-08T16:51:57.1576505Z Checking commit: QCLINUX: arm64: dts: qcom: monaco: Add RTSS Mailbox device tree overlay
2026-06-08T16:51:57.1591295Z Commit summary does not start with a required prefix

The check-patch-compliance checker enforces that commit subjects must start with one of the accepted prefixes that indicate the patch's upstream status:

  • UPSTREAM: - patch already merged in mainline
  • FROMLIST: - patch submitted to upstream mailing list
  • BACKPORT: - backported from another branch/tree
  • Subsystem-specific prefixes (e.g., dt-bindings:, arm64: dts:)

Affected commits:

  1. dcc012cbe325 - "QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs"
  2. df26da30a613 - "QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay"
  3. aebb60daed31 - "QCLINUX: arm64: dts: qcom: monaco: Add RTSS Mailbox device tree overlay"

Fix: Reword commit subjects to use proper subsystem prefixes:

  1. Commit 1 - Change from:

    QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs
    

    To:

    dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs
    
  2. Commit 2 - Change from:

    QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay
    

    To:

    arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay
    
  3. Commit 3 - Change from:

    QCLINUX: arm64: dts: qcom: monaco: Add RTSS Mailbox device tree overlay
    

    To:

    arm64: dts: qcom: monaco: Add RTSS Mailbox device tree overlay
    

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/675/head:pr-675
git checkout qcom-6.18.y
git merge --no-commit pr-675
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head <head-sha>

How to fix:

# Interactive rebase to reword commit messages
git rebase -i HEAD~3

# In the editor, change 'pick' to 'reword' for all 3 commits
# Then update each commit message to remove 'QCLINUX: ' prefix

# Force push the updated branch
git push --force-with-lease

Verdict

1 blocker to fix: The check-patch-compliance failure must be resolved by removing the QCLINUX: prefix from all three commit subjects and using proper subsystem-style prefixes instead. All other checkers passed successfully.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Add IPCC_CLIENT_RTSS0/1/2/3 client ID definitions (27-30) to
the qcom-ipcc dt-bindings header for use by the RTSS Mailbox
device tree overlay.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
Add lemans-rtss-mb.dtso overlay for Lemans platform providing:
  - ipcc_computeL1: IPCC Compute-L1 controller
  - rtss_mailbox: RTSS Mailbox device node.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
@snegi-qti snegi-qti reopened this Jun 10, 2026
Add monaco-rtss-mb.dtso overlay for Monaco platform providing:
- ipcc_computeL1: IPCC Compute-L1 controller
- rtss_mailbox: RTSS Mailbox device node.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ◻️ ◻️ ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ◻️ ◻️ ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ◻️ ◻️ ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ◻️ ◻️ ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ◻️ ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ❌ Fail ◻️
shmbridge ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@qlijarvis

Copy link
Copy Markdown

PR #675 — validate-patch

PR: #675

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #675 - Add RTSS Mailbox support for Lemans and Monaco platforms
Upstream commit: N/A (vendor-only QCLINUX patches)
Verdict: ✅ PASS

Commit Message

Patch 1/3: QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs

Check Status Note
Subject matches upstream N/A Vendor-only (QCLINUX prefix)
Body preserves rationale Clear description of added client IDs (27-30)
Fixes tag present/correct N/A Not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor change

Patch 2/3: QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay

Check Status Note
Subject matches upstream N/A Vendor-only (QCLINUX prefix)
Body preserves rationale Lists components added (ipcc_computeL1, rtss_mailbox)
Fixes tag present/correct N/A Not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor change

Patch 3/3: QCLINUX: arm64: dts: qcom: Monaco: Add RTSS Mailbox device tree overlay

Check Status Note
Subject matches upstream N/A Vendor-only (QCLINUX prefix)
Body preserves rationale Lists components added (ipcc_computeL1, rtss_mailbox)
Fixes tag present/correct N/A Not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor change

Diff

Patch 1/3:

File Status Notes
include/dt-bindings/mailbox/qcom-ipcc.h Adds 4 sequential RTSS client IDs (27-30) between WPSS (24) and GPDSP0 (31)

Patch 2/3:

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds lemans-rtss-mb.dtbo in alphabetical order
arch/arm64/boot/dts/qcom/lemans-rtss-mb.dtso New overlay with proper SPDX (BSD-3-Clause), includes, and node structure

Patch 3/3:

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds monaco-rtss-mb.dtbo in alphabetical order
arch/arm64/boot/dts/qcom/monaco-rtss-mb.dtso New overlay with proper SPDX (BSD-3-Clause), includes, and node structure

Verdict

All three patches are well-formed vendor-only changes. Commit messages are clear and concise. The dt-bindings additions are properly sequenced (IDs 27-30 fill the gap between 24 and 31). Both device tree overlays are identical in content (appropriate for shared hardware configuration), properly formatted with correct SPDX headers (BSD-3-Clause), required includes, and use the newly defined IPCC client IDs. Makefile entries are added in alphabetical order. No issues found—ready to merge.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #675 — checker-log-analyzer

PR: #675
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27287418892

Checker Result Summary
Checker Result Summary
checkpatch All 3 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check All device tree builds validated successfully
sparse-check Static analysis completed without new warnings
check-uapi-headers No changes to UAPI headers detected
check-patch-compliance FAILED - All 3 commits missing required prefix
tag-check N/A Not applicable for this branch
qcom-next-check ⏭️ Not applicable - QCLINUX commits allowed

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #675 - Add RTSS Mailbox device tree overlays for Lemans and Monaco
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27287418892

Checker Result Summary
checkpatch All 3 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check All device tree builds validated successfully
sparse-check Static analysis completed without new warnings
check-uapi-headers No changes to UAPI headers detected
check-patch-compliance FAILED - All 3 commits missing required prefix
tag-check N/A Not applicable for this branch
qcom-next-check ⏭️ Not applicable - QCLINUX commits allowed

❌ check-patch-compliance

Root cause: All three commits use QCLINUX: prefix but lack the required FROMLIST:, UPSTREAM:, or BACKPORT: prefix that indicates the patch's upstream status.

Failure details:

2026-06-10T16:04:46.5510562Z Checking commit: QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs
2026-06-10T16:04:46.5525406Z Commit summary does not start with a required prefix
2026-06-10T16:04:46.5573835Z Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay
2026-06-10T16:04:46.5588069Z Commit summary does not start with a required prefix
2026-06-10T16:04:46.5636841Z Checking commit: QCLINUX: arm64: dts: qcom: Monaco: Add RTSS Mailbox device tree overlay
2026-06-10T16:04:46.5651011Z Commit summary does not start with a required prefix

Affected commits:

  1. 038e08007b6c - QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs
  2. f9e0c595ae6b - QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay
  3. 5c6149c05f6c - QCLINUX: arm64: dts: qcom: Monaco: Add RTSS Mailbox device tree overlay

Fix: The check-patch-compliance checker enforces that commit subjects must start with one of these prefixes to indicate upstream status:

  • UPSTREAM: - for patches already merged in mainline Linux
  • FROMLIST: - for patches posted to upstream mailing lists but not yet merged
  • BACKPORT: - for patches backported from a newer kernel version

Since these are Qualcomm-specific downstream additions (RTSS mailbox overlays for internal platforms), you have two options:

Option 1 (Recommended): If these patches are intended for upstream submission, post them to the appropriate mailing lists first, then rebase with FROMLIST: prefix:

FROMLIST: dt-bindings: mailbox: qcom-ipcc: Add RTSS client IDs
FROMLIST: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay
FROMLIST: arm64: dts: qcom: Monaco: Add RTSS Mailbox device tree overlay

Option 2: If these are downstream-only patches that will never go upstream, the QCLINUX: prefix should be sufficient. In this case, the check-patch-compliance checker may need to be updated to allow QCLINUX: as a valid prefix for downstream-only commits, or this check should be waived for this PR.

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/675/head:pr-675
git checkout pr-675
# Clone the checker scripts
git clone https://github.com/qualcomm-linux/kernel-checkers.git
bash kernel-checkers/check-patch-compliance.sh --kernel-src . --base e74f856916e2 --head 5c6149c05f6c

Verdict

1 blocker to fix: The check-patch-compliance failure must be resolved before merge. All other checkers passed successfully. The fix requires either:

  1. Adding FROMLIST: prefix if patches will be upstreamed, or
  2. Confirming that QCLINUX: prefix is acceptable for downstream-only patches and updating the compliance checker accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants